Repository navigation
Fail flows on settings Temporal refuses and close raw value gaps - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flow given step timeouts or a
NoRetrytimeout name Temporal refuses stayed Running with its tasks failing, so nobody heard about it. These settings now fail the flow at once, while settings Temporal accepts keep running, so these checks do not fail a flow in flight on upgrade.IsInvalidConfigErrorrecognizes these failures, also after they leave the flow or get wrapped byAbortor%w, and anything the server answersInvalidArgument, so a queue consumer can drop what sending again cannot fix. Limits the server sets for itself, such as the length of a name, are not checked.This also closes the gaps between the docs and the codec: a slice of a named byte type and a pointer of any depth now travel raw, so
var out *stringworks as an output. Those values read differently across the upgrade and the bytes do not say which form they are in, so flows carrying them must finish before upgrading, and the release notes will say so.WithErrorIfRunningsurvives a laterWithConfig, the map type is nowLogAttributeMap, andNewLogExportergives a host with its own provider the same exporterInitLogExportuses.