Skip to content

Fail flows on settings Temporal refuses and close raw value gaps - #6

Merged
liran merged 11 commits into
mainfrom
fix/config-validation-and-codec-gaps
Nov 5, 2026
Merged

liran merged 11 commits into
mainfrom
fix/config-validation-and-codec-gaps

Conversation

@liran

@liran liran commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

A flow given step timeouts or a NoRetry timeout name Temporal refuses stayed Running with its tasks failing, so nobody heard about it. These settings now fail the flow at once, while settings Temporal accepts keep running, so these checks do not fail a flow in flight on upgrade. IsInvalidConfigError recognizes these failures, also after they leave the flow or get wrapped by Abort or %w, and anything the server answers InvalidArgument, so a queue consumer can drop what sending again cannot fix. Limits the server sets for itself, such as the length of a name, are not checked.

This also closes the gaps between the docs and the codec: a slice of a named byte type and a pointer of any depth now travel raw, so var out *string works as an output. Those values read differently across the upgrade and the bytes do not say which form they are in, so flows carrying them must finish before upgrading, and the release notes will say so. WithErrorIfRunning survives a later WithConfig, the map type is now LogAttributeMap, and NewLogExporter gives a host with its own provider the same exporter InitLogExport uses.

@liran liran self-assigned this Nov 5, 2026
@liran liran changed the title Reject settings Temporal cannot run and close raw value gaps Fail flows on settings Temporal refuses and close raw value gaps Nov 5, 2026
@liran
liran merged commit ac3a70d into main Nov 5, 2026
4 checks passed
@liran
liran deleted the fix/config-validation-and-codec-gaps branch November 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant