Skip to content

Validate human intelligence review decisions in CI - #128

Merged
basicmi merged 2 commits into
masterfrom
intelligence-review-ledger-validation
Nov 17, 2026
Merged

basicmi merged 2 commits into
masterfrom
intelligence-review-ledger-validation

Conversation

@basicmi

@basicmi basicmi commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Motivation

PR #127 connected the Evidence Review Workbench to the persistent decision ledger. The ledger was validated when the next weekly discovery consumed it, but a malformed committed decision could therefore remain unnoticed until that scheduled run.

Changes

  • Add a shared strict validator for the human decision ledger.
  • Validate exact schema and row fields, unique lowercase Claim IDs, allowed outcomes, reviewer identity, rationale length, timezone-aware timestamps and future dates.
  • Optionally validate Claim IDs against a persisted review-state snapshot.
  • Reuse the same validator in the weekly review-state tracker, keeping CI and runtime rules aligned.
  • Run the standalone ledger validation and its unit tests in the repository's data-validation CI.
  • Document local validation and the distinction between record validity, reviewer authentication and factual verification.

Safety

The validator does not authenticate reviewer identity, inspect source content, verify claims, or modify company/product registries. It only validates decision-record structure and workflow consistency. The separate human review and Evidence-to-PR approval remain required.

Tests

Covers empty and valid ledgers, every allowed outcome, duplicate/unknown/malformed Claim IDs, unknown/missing fields, invalid decisions, reviewer and rationale requirements, invalid/naive/future timestamps, timezone normalization, and the CLI entry point.

@basicmi
basicmi merged commit b5cdb8a into master Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant