Open Contacts with o, and attachments with Enter - #535
Merged
Merged
Conversation
The Contacts tab underlines the o in its name, but the key that opened it was Shift+O, so pressing the letter the tab points at did nothing. Mail, Calendar and Journal underline a capital, so their hints were already right. The C that starts "Contacts" belongs to Calendar, which leaves o, and o now opens Contacts from anywhere. Shift+O still works, the way HEY's letter shortcuts answer either case. o used to open the selected attachment in a thread. That moves to Enter, which already opens a link once Tab has picked one: with a link selected Enter opens the link, and otherwise it opens the selected attachment. Escape clears the link. The help bar offers Enter for the attachment only while no link is selected, since the link's footer already says what Enter does.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The shortcut routing, contextual help, documentation, and automated coverage are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Updates TUI navigation so o opens Contacts and Enter opens attachments unless a link is selected.
Changes:
- Adds lowercase
oas the Contacts shortcut while retaining Shift+O. - Moves attachment opening from
oto Enter with link-selection precedence. - Updates help text, documentation, and tests.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
internal/tui/tui.go |
Updates global shortcut help. |
internal/tui/tui_test.go |
Tests Contacts and Enter routing. |
internal/tui/nav.go |
Maps o/O to Contacts. |
internal/tui/mail.go |
Routes Enter to links or attachments. |
internal/tui/mail_test.go |
Updates attachment-opening tests. |
docs/tui.md |
Documents revised shortcuts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Contacts tab underlines the o in its name, but the key that opened it was Shift+O, so pressing the letter the tab points at did nothing. Mail, Calendar and Journal underline a capital, so their hints were already right. The C that starts "Contacts" belongs to Calendar, which leaves o.
onow opens Contacts from anywhere, including inside a thread. Shift+O still works, the way HEY's letter shortcuts answer either case. HEY's web app has no Contacts shortcut to match, and itso(Power Through) has no counterpart in the TUI.oused to open the selected attachment in a thread; that moves to Enter. With a link selected (Tab), Enter opens the link as before; otherwise it opens the selected attachment. Escape clears the link.enter open attachmentonly while no link is selected, since the link footer already says what Enter does, and the section row now readsshift+M/C/J jump · o contacts.docs/tui.mdcovers both.Before
In a thread, Enter does nothing and
oopens the attachment; Contacts needs Shift+O.After
Enter opens the attachment, then
ogoes to Contacts.Summary by cubic
The Contacts tab underlines
o, but the shortcut that opened it was Shift+O — so the letter the tab points at did nothing.onow opens Contacts from anywhere, including inside a thread; Shift+O still works, and the attachment shortcut in a thread moves fromoto Enter.enter open attachmentonly while no link is selected, since the link footer already says what Enter does.docs/tui.mdreflects both shortcuts.Written for commit 4f7b6b7. Summary will update on new commits.