Conversation
HEY stores the configured From in message.sender while creator remains the account user; threadload dropped sender and thread read therefore made successful sends appear to use the wrong address. Retain and display the sender without changing creator.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The only unresolved comment is a non-blocking documentation nit.
Review effort: Balanced
Findings: None
What changed in this PR
Preserves HEY’s selected send-as identity separately from the account creator and displays it in CLI and TUI thread reads.
Changes:
- Retains and accounts for sender metadata.
- Exposes sender identity across CLI and TUI formats.
- Adds regression tests and documentation.
Non-blocking note: update skills/hey/SKILL.md to document the new sender field.
| File | Description |
|---|---|
internal/tui/mail.go |
Displays the selected sender identity. |
internal/tui/mail_test.go |
Tests TUI send-as rendering. |
internal/threadload/threadload.go |
Retains and budgets sender metadata. |
internal/threadload/threadload_test.go |
Tests sender retention and budgeting. |
internal/mail/entry.go |
Adds sender data to mail entries. |
internal/mail/entry_test.go |
Tests creator/sender separation. |
internal/cmd/topic.go |
Exposes and formats sender data. |
internal/cmd/topic_test.go |
Tests sender serialization and formatting. |
internal/cmd/thread_sender_test.go |
Adds end-to-end send/read regression coverage. |
internal/cmd/thread_partial_test.go |
Verifies unread entries omit sender metadata. |
docs/tui.md |
Documents TUI sender display. |
docs/cli.md |
Documents CLI sender semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
Fixed - the HEY skill now explains |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #483.
HEY stores the selected From address in
sender, whilecreatorstays the account user. Keep and show the sender in CLI and TUI thread reads.Red send/read regression now passes;
make testandmake lintpass. A live dev send succeeded, but dev search returned 500, so live readback was not verified.Summary by cubic
Fixes #483. Thread reads now show the actual send-as address HEY recorded, instead of always displaying the account user's address.
Changes
senderthroughthreadloadand displays it in CLI, TUI, HTML, and Markdown output;creatorstays the account user.senderwhen the entry's message was not read or on index-only formats (--count,--ids-only).senderfield indocs/cli.md,docs/tui.md, andskills/hey/SKILL.md.Written for commit b40768b. Summary will update on new commits.