Skip to content

August 2025 Audit fixes#137

Merged
stevieraykatz merged 7 commits into
mainfrom
audit-fixes-20250813
Aug 15, 2025
Merged

August 2025 Audit fixes#137
stevieraykatz merged 7 commits into
mainfrom
audit-fixes-20250813

Conversation

@stevieraykatz

@stevieraykatz stevieraykatz commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Add strict pragma to foundry.toml
  2. Add input validation to AddrResolver and add default coinType handling to AddrResolver

@cb-heimdall

cb-heimdall commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stevieraykatz stevieraykatz marked this pull request as ready for review August 13, 2025 19:01
amiecorso
amiecorso reviewed Aug 14, 2025
View reviewed changes
Comment thread src/L2/resolver/AddrResolver.sol
///
/// @dev Complies with ENSIP-9 and ENSIP-11.
/// @dev Complies with ENSIP-9, ENSIP-11 and ENSIP-19.
/// Will return `default` address if there is no address set for a specific EVM cointype.

@amiecorso amiecorso Aug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this behavior is defined in one of these ENSIPs, since returning something based on the default cointype v.s. returning nothing is definitely a meaningful change in behavior.

@amiecorso amiecorso Aug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the addr get set for the default coinType when registered?

@stevieraykatz stevieraykatz Aug 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default was a late addition to the ENSIP-19 spec.

amiecorso
amiecorso reviewed Aug 14, 2025
View reviewed changes
Comment thread src/L2/resolver/AddrResolver.sol Outdated
@amiecorso amiecorso self-requested a review August 14, 2025 02:30
@amiecorso

amiecorso commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Having just added an audit to a repo, it occurs to me this could be a nice place to add the audit report that's inspiring these changes too, or just to make a ticket so as not to forget

amiecorso
amiecorso approved these changes Aug 14, 2025
View reviewed changes

@amiecorso amiecorso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just some questions and a nit, otherwise lgtm! congrats on such minimal audit findings 🎉

@cb-heimdall

cb-heimdall commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Review Error for amiecorso @ 2025-08-14 02:33:25 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@amiecorso amiecorso self-requested a review August 14, 2025 02:34
amiecorso
amiecorso approved these changes Aug 14, 2025
View reviewed changes

@amiecorso amiecorso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops gotta reapprove and hit 2fa

@cb-heimdall

cb-heimdall commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Review Error for amiecorso @ 2025-08-14 02:34:38 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@amiecorso amiecorso self-requested a review August 14, 2025 02:49
amiecorso
amiecorso previously approved these changes Aug 14, 2025
View reviewed changes

@amiecorso amiecorso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd time's a charm after updating iOS

@cb-heimdall

cb-heimdall commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Review Error for OGraham-cb @ 2025-08-14 21:49:08 UTC
User must have write permissions to review

@cb-heimdall

cb-heimdall commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Review Error for OGraham-cb @ 2025-08-14 22:20:22 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

OGraham-cb
OGraham-cb previously approved these changes Aug 14, 2025
View reviewed changes
@cb-heimdall

cb-heimdall commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Review Error for OGraham-cb @ 2025-08-14 22:24:41 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@stevieraykatz stevieraykatz merged commit ba6ab36 into main Aug 15, 2025
7 checks passed
@stevieraykatz stevieraykatz deleted the audit-fixes-20250813 branch August 15, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amiecorso amiecorso Awaiting requested review from amiecorso

1 more reviewer

@OGraham-cb OGraham-cb OGraham-cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevieraykatz @cb-heimdall @amiecorso @OGraham-cb