Skip to content

ENSIP-19 Migration compatible UpgradeRegistrarController#134

Merged
stevieraykatz merged 16 commits into
mainfrom
ensip19-migration
Aug 8, 2025
Merged

ENSIP-19 Migration compatible UpgradeRegistrarController#134
stevieraykatz merged 16 commits into
mainfrom
ensip19-migration

Conversation

@stevieraykatz

@stevieraykatz stevieraykatz commented Jun 24, 2025

Copy link
Copy Markdown
Member

Our strategy for migrating to ENSIP-19 support has shifted slightly. It requires some changes to our UpgradeableRegistrarController to take on the responsibility of our ReverseRegistrarV2 dual write method.

@cb-heimdall

cb-heimdall commented Jun 24, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment thread src/L2/UpgradeableRegistrarController.sol Fixed
@stevieraykatz stevieraykatz marked this pull request as ready for review July 14, 2025 18:09
@amiecorso amiecorso self-requested a review August 5, 2025 22:06
@stevieraykatz stevieraykatz merged commit a7e3f19 into main Aug 8, 2025
7 checks passed
@stevieraykatz stevieraykatz deleted the ensip19-migration branch August 8, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants