Skip to content

Add custom buffer constructor#21

Open
TheMadman wants to merge 2 commits into
barrust:masterfrom
TheMadman:custom-buffer
Open

Add custom buffer constructor#21
TheMadman wants to merge 2 commits into
barrust:masterfrom
TheMadman:custom-buffer

Conversation

@TheMadman

@TheMadman TheMadman commented Feb 4, 2024

Copy link
Copy Markdown

Implements the ability to pass a custom memory buffer for use in the CMS struct.

Could be useful for e.g. mmap'd buffers for graceful restart, shared memory buffers for syncing between processes, etc.

Has appropriate documentation/warnings

@codecov

codecov Bot commented Feb 23, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.79%. Comparing base (4fd7e2a) to head (d76b55c).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/count_min_sketch.c 52.17% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   96.88%   93.79%   -3.10%     
==========================================
  Files           2        2              
  Lines         257      274      +17     
==========================================
+ Hits          249      257       +8     
- Misses          8       17       +9     
Files with missing lines Coverage Δ
src/count_min_sketch.h 100.00% <ø> (ø)
src/count_min_sketch.c 93.30% <52.17%> (-3.32%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant