Deployment: AutoRange (ReClamm) Pool Factory V3 - #398
Merged
Merged
Conversation
…e non-standard runs?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment: AutoRange (ReClamm) Pool Factory V3
There is a small code change. Turns out there was an error in the input.ts that I needed to fix. (It actually worked accidentally, but I wanted it to be correct. If we ever changed the flags to non-false it would break.)
I got quite an education in how HyperEVM works. There's some setup needed to start deploying with a new account. See PR #397 for scripts to automate that next time. (I've also updated our internal deployment docs with all this information.)
It would not automatically verify on Plasma. It said it succeeded: but was lying. It was not verified in the UI. Plasma and X-Layer aren't supported in Etherscan V2, so I had to use --v1 to go through RouteScan; probably something dropped there.
Anyway I had to verify it manually, and included the JSON to upload for all three contracts (and the constructor args as a string). Thought I might as well include that, in case we add it to another chain and have similar issues.
Deployment tasks checklist:
readmeCHANGELOGis updatedIssue Resolution