Update LBP Pool ABI. Add new LBP seedless integration test.#818
Merged
Conversation
MattPereira
reviewed
Mar 25, 2026
Comment on lines
+159
to
+171
| await approveSpenderOnTokens( | ||
| client, | ||
| testAddress, | ||
| [BAL.address], | ||
| PERMIT2[chainId], | ||
| ); | ||
|
|
||
| await approveTokens( | ||
| client, | ||
| testAddress, | ||
| [BAL.address], | ||
| protocolVersion, | ||
| ); |
Contributor
There was a problem hiding this comment.
curious about the double approve
seems like possible to dump approveSpenderOnTokens since it runs as part of approveTokens helper
( verified by removing locally and test still passes )
b-sdk/test/lib/utils/helper.ts
Lines 99 to 106 in 2744e0a
MattPereira
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
added permit2 sig test to challenge claude to do a snapshot and pattern match the other tests
feel free to roll back for any reason if you prefer 2db693d
Member
Author
Nice! thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.