Implementation 3D displacements in Carbonate growth and Wave forcing modules#30
Open
andresrcorcho wants to merge 5 commits into
Open
Implementation 3D displacements in Carbonate growth and Wave forcing modules#30andresrcorcho wants to merge 5 commits into
andresrcorcho wants to merge 5 commits into
Conversation
All fns required from the Bdls side to enable the carbonate module in UW-Bdls coupled models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation enables the use of 3D displacements when using both the Carbonate growth and wave modules. The carbonate module now includes a "Pelagic rain proportion" which is independent of the clastic, species1 and species2 proportions previously implemented. Furthermore, this version also addresses the issue with the checkpointing of .sed files when running Underworld-Bdls coupled models by rounding to 0 decimal positions the time steps injected into Bdls from Underworld.