Skip to content

Bus end#576

Merged
raimohanska merged 2 commits into
baconjs:masterfrom
phadej:bus-end
May 11, 2015
Merged

Bus end#576
raimohanska merged 2 commits into
baconjs:masterfrom
phadej:bus-end

Conversation

@phadej

@phadej phadej commented Apr 19, 2015

Copy link
Copy Markdown
Member

Includes commits from #573

@raimohanska

Copy link
Copy Markdown
Contributor

Hmm.. the "Bacon.Bus does not plug after end(), second variant" test is still failing.

@raimohanska

Copy link
Copy Markdown
Contributor

To me it seems that the test is wrong:

  it "does not plug after end(), second variant", ->
    failed = false
    busA = new Bacon.Bus()
    busB = new Bacon.Bus()
    busB.onValue(-> failed = true;)
    busB.plug(busA)
    busA.push('foo')
    busB.end()
    expect(failed).to.equal(false)

You plug busA before ending busB, so it's correct to pass the "foo" event through, right?

@phadej

phadej commented Apr 20, 2015

Copy link
Copy Markdown
Member Author

Ah seems, I swapped the lines when "cleaning up the mess".

@phadej

phadej commented Apr 20, 2015

Copy link
Copy Markdown
Member Author

Fixed.

@raimohanska raimohanska merged commit c33fa93 into baconjs:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants