Conversation
|
Thanks! |
|
Thanks @ykalani, and sorry this stalled after a one-word reply. Checked it against main: it is not superseded. The shipped Gemini leg writes The branch is 507 commits behind and
Are you up for a rebase? If we don't hear back in 14 days I'll close this to keep the queue honest — it can be reopened any time, and the design above is the whole review. |
50ec764 to
3ead2c2
Compare
There was a problem hiding this comment.
Rebased onto current main and pushed the update to this PR.
Added all three requested conventions:
- Opt-outs via
--skip-antigravity(-SkipAntigravityin PowerShell),PLANNOTATOR_SKIP_ANTIGRAVITY_INSTALL, andskipInstall.antigravity. - Detection reporting that distinguishes installed, skipped with reason, and not detected.
- Uninstall cleanup for both Antigravity layouts, preserving unrelated host files.
Installer and uninstall tests: 197 passed, 9 platform skips. Coverage includes Bash, PowerShell, and CMD, opt-out precedence, repeat installs, and preservation of existing files when skipped.
Ready for another review. Thanks for the guidance!
|
Thanks for the rebase, the opt-out, reporting, and uninstall work is exactly right and should stay. But checked against the Antigravity CLI itself, the plugin it writes can't fire:
So this needs the runtime adapter (payload branch + an |
Adds native Antigravity CLI plan-file review and installer support.
When Antigravity is detected, the installer writes
~/.gemini/config/plugins/plannotator/{plugin.json,hooks.json}and installs review/annotation skills.~/.gemini/antigravity-cliis only a detection signal, never an installation destination.The named
PreToolUsehook intercepts writes to the current conversation'simplementation_plan.md. The runtime reads Antigravity's camelCasetoolCallpayload, opens Plannotator with theantigravityorigin, and returns native allow/deny decisions with feedback. Incremental plan edits request a full-file resubmission; unrelated writes abstain with{}.Installation safeguards:
PLANNOTATOR_ORIGIN=antigravityfor review and annotation.~/.gemini. Profiles with Gemini-specific signals retain both integrations.Scope and compatibility:
Validation covers temporary-home installs in Bash, PowerShell, and CMD; old-binary preservation; Gemini coexistence; repeat installs; quoted binary paths; opt-outs; uninstall; and native payload/decision handling. Installed plugin shape is also checked with
agy plugin validatewhen available. Seeapps/antigravity/README.mdfor the live acceptance checklist.