fix: null-check cert_and_key fields in load helpers#5932
Open
jouho wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add null-checks on
cert_and_keyand the field being dereferenced ins2n_cert_chain_and_key_set_cert_chain_from_stuffer ands2n_cert_chain_and_key_set_private_key_from_stuffer.Why
Both helpers dereference
cert_and_key->cert_chain/cert_and_key->private_keywithout any guard, while their peers s2n_cert_chain_and_key_load_sans and _load_cns lead with POSIX_ENSURE_REF on the field they use.How
Add POSIX_ENSURE_REF(cert_and_key) and the field-specific POSIX_ENSURE_REF at the top of both helpers, matching the pattern used by the san/cn load functions.
Testing
All tests pass.
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.