fix(dc): Enable panic clippy lints in s2n-quic-dc#3116
Open
Mark-Simulacrum wants to merge 1 commit into
Open
Conversation
This doesn't fix anything just yet, just allowing the lints across the code with reasons annotated. Future commits/PRs will actually adjust functionality.
Mark-Simulacrum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This doesn't fix anything just yet, just allowing the lints across the s2n-quic-dc crate with reasons annotated. FIXME reasons correspond to where we expect some follow up scrutiny to be required.
Call-outs:
Once we upgrade to 1.95 Clippy, we should be able to use allow-unwrap-types (see docs) to avoid the numerous sites where we're unwrapping potentially poisoned lock guards. Technically I think CI uses stable (i.e., >1.95) Clippy, but it's not the default in local
cargo clippyruns and I think the cost of errors when you forget to pass+stableis higher than a scattering of extra lint allows.Some of the lints are also allowed a bit in the wrong place (e.g., function rather than expression boundary). I think we can over time clean things up -- my hope is that we can reduce the amount of sites beyond just fixing FIXMEs -- but I'm not too worried about it for now. The likelihood of missing a new unwrap / panic in code review is fairly low and we can drive-by fix them as we go.
Testing:
CI passes -- which runs clippy, and would notice if there's new lints from this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.