fix: Return early if connection errors while processing first packet in datagram#3110
Merged
Conversation
maddeleine
commented
Jun 4, 2026
| measure#recovery_metrics.congestion_window=12000 | ||
| measure#recovery_metrics.bytes_in_flight=[REDACTED] | ||
| count#recovery_metrics.congestion_limited=false | ||
| count#packet_received=1 |
Contributor
Author
There was a problem hiding this comment.
This change is due to the fact that now the client is now not continuing to process OneRtt packets after receiving the first ConnectionClosure above on line 256.
Contributor
|
Do we need to make any change to stop processing packets from subsequent datagrams when the connection is closing after an error? |
Contributor
Author
I want to put that fix in a separate PR. |
WesleyRosenblum
approved these changes
Jun 4, 2026
WesleyRosenblum
left a comment
WesleyRosenblum
left a comment
Contributor
There was a problem hiding this comment.
Can you check on those interop failures before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
N/A
Description of changes:
We had a regression in s2n-quic a while ago, we removed a return statement when the connection is closing due to an error. This causes s2n-quic to continue reading packets in a datagram after connection closure, which can make dc-quic panic under atypical network conditions. I wrote a test to reproduce the failure scenario and added the return statement back in.
Call-outs:
Testing:
Includes test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.