fix: clippy lint updates for rust version 1.89.0#2750
Merged
Conversation
jouho
marked this pull request as ready for review
August 11, 2025 23:17
boquan-fang
self-requested a review
August 11, 2025 23:37
Contributor
|
The new clippy lint can be found in https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint. |
boquan-fang
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
Minimal changes to address clippy warnings introduced by new rust version 1.89.0.
Initial PR to address this issue contained changes that weren't necessarily required by clippy
Call-outs:
cargo --fixdoes not apply auto-fix, therefore had to manually audit the clippy warnings. Reason discussed: rust-lang/rust#144588Testing:
Tested locally by running
confirmed clippy job passes now
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.