Regroup Styles settings into Your Styles and Shared Styles groups#1909
Draft
kmcginnes wants to merge 2 commits into
Draft
Regroup Styles settings into Your Styles and Shared Styles groups#1909kmcginnes wants to merge 2 commits into
kmcginnes wants to merge 2 commits into
Conversation
Split the single Style Sharing / Danger Zone layout into two action groups mirroring General settings' Manage Configuration Data group. Buttons drop to single words (Save, Load, Reset) now that the group titles say what they act on; each Reset button keeps a distinct aria-label so the two are distinguishable to screen readers. Part of #1898
The Styles settings regroup removed the last Group danger variant usage; drop the now-dead variant and its header styling. It can be reintroduced if a danger grouping is needed again. Part of #1898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructures the Styles settings screen into two action groups that mirror the "Manage Configuration Data" group in General settings:
With the actions grouped by what they act on, the buttons drop to single words (Save, Load, Reset) instead of the previous full phrases. Each Reset button carries a distinct
aria-labelso the two remain distinguishable to screen readers.The old layout paired a "Style Sharing" group with a separate danger-variant "Danger Zone" group; that danger grouping is intentionally gone, so the now-unused
dangervariant is dropped from the sharedGroupcomponent (it can be reintroduced later if needed).This keeps the existing "shared styles" terminology unchanged — the rename to "theme" is a separate follow-up.
How to read
SettingsStyles.tsx— the core change: the two-group layoutGroup.tsx— supporting cleanup: removes the deaddangervariantThe button files (
Save/Load/Reset*StylesButton.tsx) are small single-word label swaps plusaria-labels on the two Reset triggers.Validation
pnpm checkspassespnpm testpasses (Settings suite: 13 tests, including the updatedSaveStylesButtonlabel assertion)Related Issues