aws-cloudwatch-metrics: extend permissions, update image#1343
Open
rcanavan wants to merge 1 commit into
Open
Conversation
* aws-cloudwatch-metrics: add list + watch permissions on endpointslices * aws-cloudwatch-metrics: add list + watch permissions on services * aws-cloudwatch-metrics: bump image version to the latest available * aws-cloudwatch-metrics: bump chart version to 0.0.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-cloudwatch-metrics: add list + watch permissions on endpointslices
aws-cloudwatch-metrics: add list + watch permissions on servi
ces
aws-cloudwatch-metrics: bump image version to the latest available
aws-cloudwatch-metrics: bump chart version to 0.0.12
Description of changes
With recent k8s versions (we're using 1.35 here), aws-cloudwatch metrics reports the following errors:
reflector.go:166] \"Unhandled Error\" err=\"k8s.io/client-go@v0.32.3/tools/cache/reflector.go:251: Failed to watch *v1.EndpointSlice: failed to list *v1.EndpointSlice: endpointslices.discovery.k8s.io is forbidden: User \\\"system:serviceaccount:amazon-cloudwatch:aws-cw-agent\\\" cannot list resource \\\"endpointslices\\\" in API group \\\"discovery.k8s.io\\\" at the cluster scope\" logger=\"UnhandledError\"","k8":{"pod_name":"aws-cloudwatch-metrics-8d8tj","host":"...","pod_ip":"..."},"kubernetes":{"namespace_name":"amazon-cloudwatch","container_name":"aws-cloudwatch-metrics"}}and
reflector.go:569] k8s.io/client-go@v0.32.3/tools/cache/reflector.go:251: failed to list *v1.Service: services is forbidden User "system:serviceaccount:amazon-cloudwatch:aws-cw-agent" cannot list resource "services" in API group "" in the namespace "amazon-cloudwatch"This pull request adds the required permissions to the ClusterRole, although I'm not sure if the list/watch services permissions should be more limited.
Additionally it updates the app and image versions to the most recent image available (currently 1.300069.0b1529).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.