Skip to content

feat(sagemaker): Storing credentials while connecting to hyperpod spaces#8765

Open
msgupta-amazon wants to merge 14 commits into
aws:masterfrom
msgupta-amazon:reconnection-implementation
Open

feat(sagemaker): Storing credentials while connecting to hyperpod spaces#8765
msgupta-amazon wants to merge 14 commits into
aws:masterfrom
msgupta-amazon:reconnection-implementation

Conversation

@msgupta-amazon
Copy link
Copy Markdown
Contributor

Problem

We are currently not supporting reconnection on hyperpod spaces and this PR is a sub-PR for the same.

Solution

This PR allows us to store the credentials of the user which establishing initial connection.

Note

Changelog entry won't be included as part of this PR as this is a child PR and does not release a feature end-to-end.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amazon-inspector-ohio
Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link
Copy Markdown

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants