feat(sagemaker): Storing credentials while connecting to hyperpod spaces#8765
Open
msgupta-amazon wants to merge 14 commits into
Open
feat(sagemaker): Storing credentials while connecting to hyperpod spaces#8765msgupta-amazon wants to merge 14 commits into
msgupta-amazon wants to merge 14 commits into
Conversation
Modified the codeowners file to support sagemaker-code-editor team
…rting reconnection
…pta-amazon/aws-toolkit-vscode into reconnection-implementation-storing
…-storing Storing credentials and cluster metadata for reconnection
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We are currently not supporting reconnection on hyperpod spaces and this PR is a sub-PR for the same.
Solution
This PR allows us to store the credentials of the user which establishing initial connection.
Note
Changelog entry won't be included as part of this PR as this is a child PR and does not release a feature end-to-end.
feature/xbranches will not be squash-merged at release time.