Skip to content

[Test] test_upgrade_nvidia_software: fix devsettings approach by specifying the gdrcpy checksum. - #7654

Merged
gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3170/test-upgrade-nvidia-1007-1
Oct 9, 2026
Merged

gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3170/test-upgrade-nvidia-1007-1

Conversation

@gmarciani

@gmarciani gmarciani commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

test_upgrade_nvidia_software: fix devsettings approach by specifying the gdrcpy checksum.

Why the test is successful even without this change?
It succeeds only by chance, because the gdrcopy version we are upgrading in the test is the latest, which is also the one already shipped in 3.16.0+ so the default checksum is already matching.

Tests

Executed the tests below for:

  • SUCCESS: on pcluster 3.17.0 (Candidate) and 3.16.0
  • SUCCESS: on 3.15.0 with the custom component approach (expected to fail the devsettings approach as that approach is supported only on 3.16.0+).
test-suites:
  tutorials:
    test_upgrade_nvidia_software.py::test_upgrade_nvidia_software:
      dimensions:
        # The NVIDIA upgrade component targets Amazon Linux 2023 x86_64 only.
        - regions: [ {{ g4dn_2xlarge_CAPACITY_RESERVATION_2_INSTANCES_2_HOURS_NOPG_alinux2023 }} ]
          instances: [ "g4dn.2xlarge" ]
          oss: [ "alinux2023" ]
          schedulers: [ "slurm" ]
          flags: ["component"]
        - regions: [ {{ g4dn_2xlarge_CAPACITY_RESERVATION_2_INSTANCES_2_HOURS_NOPG_alinux2023 }} ]
          instances: [ "g4dn.2xlarge" ]
          oss: [ "alinux2023" ]
          schedulers: [ "slurm" ]
          flags: ["devsettings"]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Oct 7, 2026
@gmarciani
gmarciani marked this pull request as ready for review October 9, 2026 14:23
@gmarciani
gmarciani requested review from a team as code owners October 9, 2026 14:23
@gmarciani
gmarciani enabled auto-merge (rebase) October 9, 2026 14:25
@gmarciani
gmarciani force-pushed the wip/mgiacomo/3170/test-upgrade-nvidia-1007-1 branch from c18f0d8 to 4493df9 Compare October 9, 2026 14:28
@gmarciani
gmarciani disabled auto-merge October 9, 2026 14:52
@gmarciani
gmarciani merged commit bee67f6 into aws:develop Oct 9, 2026
20 checks passed
@gmarciani
gmarciani deleted the wip/mgiacomo/3170/test-upgrade-nvidia-1007-1 branch October 9, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants