Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: handle shared storage property changes in update policy (#7162)
Fixes #7162.
The shared-storage update policy passes scalar MountDir changes to SharedStorageChangeInfo, which previously called dictionary methods on the path string. The fix reads storage metadata only for changes to entire SharedStorage entries, so property changes return the existing fleet-stop validation result. The regression checks the configuration diff and its complete ACTION NEEDED report for an FSx for Lustre MountDir change with a running compute fleet. Reviewers should check that property changes retain compute and login fleet restrictions while mounting and unmounting external storage keep their existing behavior. The regression failed with an assertion before the fix and passed afterward; all 216 tests in test_config_patch.py and test_update_policy.py passed, along with Black, isort, and Flake8 checks on the changed Python files and the project's tests/pcluster/test.sh CLI smoke checks.
Regression test:
cli/tests/pcluster/config/test_config_patch.py(fails before the fix, passes after).This pull request was prepared with an AI coding assistant (OpenAI Codex driven by a verification harness) and reviewed by a person before it was opened. The regression test was checked to fail on the current code by an assertion and to pass with the fix 5/5 times in a row.