Repository navigation
Cherry-pick #7642: [integ-test] Make get-cluster/image-log-events integ tests robust to empty pages - #7647
Merged
Conversation
…empty pages GetLogEvents may return partially full or empty pages even when more events are available; `limit` is only an upper bound. The previous checks assumed `limit=1` always returned exactly one event and indexed `events[0]`, making them flaky. Replace the filter matrix with a full pagination of the log stream (until the returned token equals the one passed in) and assert the stream is not empty. Arguments like `limit` are already covered by unit tests, and don't have to be in integration tests.
hanwen-cluster
added
the
skip-changelog-update
hanwen-cluster
enabled auto-merge (rebase)
October 5, 2026 17:12
hanwen-cluster
approved these changes
Oct 5, 2026
hanwen-cluster
disabled auto-merge
October 5, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cherry-pick of #7642 to
release-3.16.Included PRs:
develop)