fix: guard transport type assertion against non-standard DefaultTransport - #644
Merged
Merged
Conversation
…port newAPITransport asserted http.DefaultTransport to *http.Transport with an unchecked assertion. http.DefaultTransport is an http.RoundTripper, and instrumentation libraries such as otelhttp replace it with a wrapper that is not an *http.Transport, so the assertion panicked at client construction. Fall back to a fresh *http.Transport when the default is not the standard transport. The API client only talks to the local Runtime and Extensions API, so it does not need to inherit any transport tuning from the wrapped default. Fixes: #642
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 82.94% 82.99% +0.04%
==========================================
Files 36 36
Lines 1425 1429 +4
==========================================
+ Hits 1182 1186 +4
Misses 240 240
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rarepolz
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#642
Description of changes:
Guard transport type assertion against non-standard DefaultTransport
newAPITransport asserted http.DefaultTransport to *http.Transport with an unchecked assertion. http.DefaultTransport is an http.RoundTripper, and instrumentation libraries such as otelhttp replace it with a wrapper that is not an *http.Transport, so the assertion panicked at client construction.
Fall back to a fresh *http.Transport when the default is not the standard transport. The API client only talks to the local Runtime and Extensions API, so it does not need to inherit any transport tuning from the wrapped default.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.