Datasets v2#1433
Merged
Merged
Conversation
Merge from main
Merge from main
…1444) When recreating a legacy dataset as a new experience dataset, existing permissions are now captured before deletion and reapplied after creation. If reapplication fails, the previous permissions are printed so the user can restore them manually.
…rience datasets (#1445) When merging a legacy dataset into a new experience dataset, top-level RowLevelPermissionDataSet and RowLevelPermissionTagConfiguration are moved into SemanticModelConfiguration.TableMap as RowLevelPermissionConfiguration, since the new experience API rejects top-level RLS attributes. ColumnLevelPermissionRules remain at the top level as the API accepts them for both legacy and new experience.
When a dataset needs to be migrated to the new QuickSight Data Preparation Experience, check if other dashboards also use it. If so, show a warning listing affected dashboards and prompt the user before proceeding with the delete/recreate migration. - Add find_dashboards_using_dataset() to discover dashboards referencing a dataset - Add _confirm_dataset_experience_migration() with yellow/red warning flow - If user declines, skip dataset update (return 'skipped' sentinel) - Update caller to suppress 'Updated dataset' message on skip
Merge from main
Merge from main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.