update: Refresh Container Insights Logs Insights lab content and screenshots - #1922
Open
arcegacardenas wants to merge 1 commit into
Open
arcegacardenas wants to merge 1 commit into
arcegacardenas wants to merge 1 commit into
Conversation
…shots Update the CloudWatch Logs Insights and application metrics dashboard instructions to match the current console UI (Discovered fields placement, panel kebab menu edit flow, and query location), and refresh the query1/query2 screenshots accordingly.
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refreshes the Container Insights CloudWatch Logs Insights lab to match the current AWS console UI:
logs-insights.md: Updated the description of automatically detected fields — Discovered fields now appears below the query rather than in the right pane.visualize-application-metrics-cloudwatch.md: Updated the dashboard panel edit flow to reflect the current UI (open the kebab menu / 3 vertical dots on the panel, then select Edit) and adjusted the wording describing where the panel query is shown.query1.webpandquery2.webpscreenshots to align with the updated instructions.Which issue(s) this PR fixes:
Fixes #
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.