Support direct Alkalinity-only input for fixed-pH screening#5
Open
TimBartholomew wants to merge 3 commits into
Open
Support direct Alkalinity-only input for fixed-pH screening#5TimBartholomew wants to merge 3 commits into
TimBartholomew wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes alkalinity handling in build_water_composition(...) for fixed-pH screening workflows.
Previously, passing alkalinity directly was broken and could fail with a NameError due to an input_formula / input_fomrula typo. In addition, alkalinity-related inputs could trigger coupled carbonate handling that caused PHREEQC to reconcile carbonate chemistry and shift the specified pH.
This change makes the direct Alkalinity path explicit:
Implementation
Validation
Ran:
Results:
Behavior Summary
Case A: direct Alkalinity
Case B: CaHCO3