Dropped second action#4
Merged
Merged
Conversation
TimBartholomew
commented
May 20, 2026
TimBartholomew
commented
Contributor
- Dropped the second action which was primarily punching diffusion coefficients and transport numbers
- Modified osmotic pressure because I think it was tied to the second action, somehow
- Added something to gitignore
avdudchenko
reviewed
May 24, 2026
|
|
||
|
|
||
| class solution_utils: | ||
| def _process_activities(self, result): |
Owner
There was a problem hiding this comment.
So we are completely dropping reporting activity coefficients for phases/species?
Osmotic pressure use this - hence the dependence (we get activities for all specie/h2o) and then use h2o to get osmotic pressure.
I think it is fine to drop all of this as I do not seem many/any use cases (I only added as I tried to see if useing raw activites would make better surrogates -it did not...)
avdudchenko
approved these changes
May 24, 2026
avdudchenko
left a comment
avdudchenko
left a comment
Owner
There was a problem hiding this comment.
Overall looks good. Can just merge once tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.