Skip to content

Remove compiler option override needed for TypeScript 4.x.#3348

Merged
novemberborn merged 3 commits into
avajs:mainfrom
kebbell:main
Jun 6, 2025
Merged

Remove compiler option override needed for TypeScript 4.x.#3348
novemberborn merged 3 commits into
avajs:mainfrom
kebbell:main

Conversation

@kebbell
Copy link
Copy Markdown
Contributor

@kebbell kebbell commented Nov 5, 2024

Please review

@novemberborn novemberborn changed the title Fixed a bug Remove compiler option override needed for TypeScript 4.x. Nov 15, 2024
Copy link
Copy Markdown
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread tsconfig.json Outdated
// See <https://github.com/microsoft/TypeScript/issues/50544>. This does not
// seem solved with 4.8.3.
"forceConsistentCasingInFileNames": false,
"forceConsistentCasingInFileNames": true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default option in the base config, so the entire compilerOptions block can be removed instead.

Comment thread tsconfig.json Outdated
"test-types"
]
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty line.

@novemberborn novemberborn dismissed their stale review June 6, 2025 20:41

Applied changes.

@novemberborn novemberborn merged commit 50e02d5 into avajs:main Jun 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants