Add ommitted forbidden relations to uniform copy of config space#1307
Open
bbudescu wants to merge 1 commit into
Open
Add ommitted forbidden relations to uniform copy of config space#1307bbudescu wants to merge 1 commit into
bbudescu wants to merge 1 commit into
Conversation
…tance with uniformly distributed hyperparameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add forbidden clauses from original config space to newly created instance with uniformly distributed hyperparameters during initial random sampling.
Reference Issues/PRs
Fixes #1306
Description, Motivation and Context
I was getting crashes when running smac3 v2.4.0 because the configs generated during the initial random sampling phase weren't satisfying the forbidden clauses.
Changes
The code does the same thing for forbidden clauses that is already being done for conditions.
Type Of Changes
What is Missing?
Checklist
developbranch.CHANGELOG.rst.Any other comments?
Not sure, since this is a bugfix, am I supposed to also make a pull request on the main branch?