Repository navigation
fix(docker): build with pnpm instead of yarn - #166
Merged
Merged
Conversation
The repo moved to pnpm in #147 but the Dockerfile still ran yarn install, which fails because package.json pins packageManager to pnpm@11.1.1. This broke the v0.4.0 release workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.4.0 release workflow failed at
yarn install:#147 switched the repo to pnpm but didn't update the Dockerfile. Lint and test use pnpm and never build the image, so nothing caught it before the first tag after the switch.
Changes
RUN corepack enable(replaces the unusedYARN_CACHE_FOLDER), so the pinned pnpm 11.1.1 is usedpnpm install --frozen-lockfileandpnpm buildreplace the yarn commandsTesting
docker build --platform linux/amd64 .succeeds locally (Done in 8.8s using pnpm v11.1.1, vite build OK, nginx config test passes)GET /returns 200 with the playground's HTMLFollow-up
Once this merges, cut a new tag (e.g.
v0.4.1) or movev0.4.0to the merge commit. Re-running the failed run will rebuild the old commit and fail again.🤖 Generated with Claude Code