refactor: sso-provider-table hook architecture#248
Open
harishsundar-okta wants to merge 13 commits into
Open
Conversation
🚀 Preview deploymentBranch: 📝 Preview URL: https://auth0-universal-components-7cl2f6quv-ui-components-217de888.vercel.app Updated at 2026-04-17T07:54:00.093Z |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 89.41% 89.41% -0.01%
==========================================
Files 159 160 +1
Lines 13334 13313 -21
Branches 1828 1359 -469
==========================================
- Hits 11923 11904 -19
+ Misses 1411 1409 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nto refactor/sso-provider-table-hook-architecture
…nto refactor/sso-provider-table-hook-architecture
harishsundar-okta
force-pushed
the
refactor/sso-provider-table-hook-architecture
branch
from
66b6fda to
ed1450d
Compare
rax7389
reviewed
Apr 17, 2026
rax7389
reviewed
Apr 17, 2026
Contributor
|
Why |
harishsundar-okta
added
refactor
rax7389
reviewed
Apr 17, 2026
rax7389
reviewed
Apr 17, 2026
rax7389
previously approved these changes
Apr 18, 2026
NaveenChand755
requested changes
Apr 20, 2026
| import type { UseSsoProviderTableServiceReturn } from '@/types/my-organization/idp-management/sso-provider/sso-provider-table-types'; | ||
|
|
||
| export const ssoProviderQueryKeys = { | ||
| all: ['sso-providers'] as const, |
Contributor
There was a problem hiding this comment.
since tanstack query is framework agnostic we can move these to core
Contributor
Author
There was a problem hiding this comment.
its moved to core
NaveenChand755
requested changes
Apr 21, 2026
| const { coreClient } = useCoreClient(); | ||
| const queryClient = useQueryClient(); | ||
| const handleError = useErrorHandler(); | ||
| const hasShownProvidersError = useRef(false); |
Contributor
Author
There was a problem hiding this comment.
Yes. It prevents the same error toast from showing multiple times when the useEffect re-runs. Without it, users could see duplicate error notifications.
…nto refactor/sso-provider-table-hook-architecture
…nto refactor/sso-provider-table-hook-architecture
|
|
||
| import { | ||
| OrganizationDetailsMappers, | ||
| SsoProviderMappers, |
Contributor
There was a problem hiding this comment.
The service should just throw, and the public hook handles all feedback — success toasts and error toasts — consistently in one place. so useErrorHandler and showToast should be in use-sso-provider-table hook, this should be a pure data layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures sso-provider-table hooks to follow the single public hook architecture with an internal service layer.
Why
The component was manually wiring two separate hooks (useSsoProviderTable + useSsoProviderTableLogic), leaking internal concerns into the component layer.
What
Packages
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and tests should be added for new functionality and existing tests should complete without errors.
Checklist