fix limited precision of std::to_string when passing args to tetgen#25
Open
jvwilliams23 wants to merge 1 commit into
Open
fix limited precision of std::to_string when passing args to tetgen#25jvwilliams23 wants to merge 1 commit into
jvwilliams23 wants to merge 1 commit into
Conversation
Contributor
Author
|
I checked the error but not clear why it is failing the test. |
Contributor
Author
|
Hey @TheBEllis, would you be able to review this PR when you get a chance please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For small max tet volumes (anything less than 1e-6 pretty much), I was getting the error that it would be truncated to 0, causing tetgen to get caught in a loop of infinitely refining. I found this was due to the precision of
to_stringwhich has been replaced with astringstream.Should now work up to double precision (for tet volume and tri area).