Repository navigation
Record patterns in do binds do not need MonadFail when they cannot fail - #525
Merged
Merged
Conversation
A record pattern in a 'do' bind was always treated as one that can
fail, so it required MonadFail even for a single-constructor type with
irrefutable field patterns:
newtype M a = M a -- Functor, Applicative, Monad; no MonadFail
data R = R { x :: Int, y :: Int }
sumR mr = do
R { x = a, y = b } <- mr
return (a + b)
RecordBind.hs: line 21, col 3: Cannot satisfy constraint: MonadFail M
failureFree had no case for record patterns (EUpdate) and fell through
to "can fail". It now treats C { f = p, .. } like the positional
pattern: failure free when the constructor is the only one and every
field pattern is; puns and '..' bind variables, so they are.
Found while compiling miso, which uses such binds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be low-hanging fruit discovered in dmjio/miso#1663.
A record pattern in a 'do' bind was always treated as one that can fail, so it required
MonadFaileven for a single-constructor type with irrefutable field patterns:failureFreehad no case for record patterns (EUpdate) and fell through to "can fail". It now treatsC { f = p, .. }like the positional pattern: failure free when the constructor is the only one and every field pattern is; puns and '..' bind variables, so they are.Found while compiling miso, which uses such binds.