fix: canonicalise HOME in transcript-tail test for macOS#68
Merged
Conversation
The macOS tempdir lives under /var/folders/... which symlinks to /private/var/folders/.... validate_transcript_path canonicalises the transcript path before the startswith(HOME) check, so the test's non-canonical HOME override failed the check on macOS while passing on Linux. Canonicalise the tempdir path before setting HOME. Also backfill the PR #67 (Ollama runtime probe) entry in ROADMAP.md under Completed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOMEoverride inhook_transcript_tail_toggle_populates_field_when_enabledso thevalidate_transcript_pathstartswith(HOME)check survives macOS's/var→/private/varsymlink resolution. Test-only change.ROADMAP.mdunderCompleted.
Test plan
cargo test --features test-support --test hook hook_transcript_tail_toggle_populates_field_when_enabledpasses locally on macOSjust cipasses (full pipeline: fmt, clippy, test, deny, doc)