fix: make Chrome download visible and fail-fast instead of hanging#861
Merged
Conversation
The Chrome .deb download used `wget -q` with no timeout, so a slow or stalled mirror connection produced no log output and could hang the build for a very long time instead of failing. - Drop `-q` and add `--progress=dot:giga` so download progress is visible in CI logs - Add `--timeout=30 --tries=3` so a stalled connection fails fast and retries instead of hanging
rdoria1
force-pushed
the
fix/chrome-download-timeout-visibility
branch
from
d958841 to
69c911a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Chrome
.debdownload in the Dockerfile useswget -qwith no timeout:RUN wget -q https://mirror.cs.uchicago.edu/.../google-chrome-stable_134.0.6998.88-1_amd64.debWith
-qthere is no log output, and with no timeout a stalled connection from a CI runner hangs the build step indefinitely (observed 40+ min vs the usual ~7-8 min) instead of failing or recovering.Change
RUN wget --progress=dot:giga --timeout=30 --tries=3 https://mirror.cs.uchicago.edu/.../google-chrome-stable_134.0.6998.88-1_amd64.deb--progress=dot:giga— replaces-qso download progress (%, speed) is visible in CI logs. Dot mode is used because the default progress bar needs a TTY and won't render in CI;gigascale (~1 MB/dot) keeps the output compact for the ~109 MB file.--timeout=30 --tries=3— a stalled connection now hits an idle timeout, drops, and retries with a fresh connection instead of hanging.Same URL, same pinned version, same sha256 verification — only the download behavior changes. No functional change to the image.
Scope / follow-up
This is a resilience + observability improvement, not a root-cause fix. The underlying fragility is depending on a single mirror that can be slow/unreachable from CI runners.
--timeoutis an idle timeout, so it catches hard stalls and (via--tries) recovers from them, but it will not abort a slow-but-progressing trickle. A fuller fix (a more reliable source, or acurltotal/min-speed limit) can follow if needed.