Validate IP-like hosts in UriAttribute and extend test coverage#359
Merged
Conversation
perkops
previously approved these changes
Apr 10, 2026
0101ae7 to
ea259d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uri.TryCreate accepts malformed IP addresses like 1231.0.0.1 by misclassifying them as DNS hostnames. This PR adds host validation to UriAttribute.IsValid that detects hosts consisting solely of digits and dots (IP-like) but not recognized as valid IPv4, and rejects them. It also significantly extends test coverage for IPAddressAttribute, UriAttribute, and the URI string extension methods.
Changes
🐛 Fixes
incorrectly accepts as DNS names
✅ Tests
attribute overload
TryIsValidHttpOrHttps, IsValidOpcTcp, and TryIsValidOpcTcp
📝 Documentation