fix(docs): correct Puppeteer env var from PUPPETEER_SKIP_CHROMIUM_DOWNLOAD to PUPPETEER_SKIP_DOWNLOAD (#794)#805
Open
armorbreak001 wants to merge 1 commit into
Conversation
…NLOAD to PUPPETEER_SKIP_DOWNLOAD (asyncapi#794) PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is deprecated in puppeteer@^24.4.0. The correct variable is PUPPETEER_SKIP_DOWNLOAD.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #794
The README instructs users to set
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true, but this environment variable is deprecated in puppeteer@^24.4.0. Setting it has no effect — Chromium is still downloaded.Fix
Replace with
PUPPETEER_SKIP_DOWNLOAD=true, which is the correct variable in modern Puppeteer versions.Verification
PUPPETEER_SKIP_DOWNLOADis the correct variablePUPPETEER_SKIP_DOWNLOAD=true npm installcorrectly skips Chromium download