Repository navigation
Show where patterns and calls are from - #17
Merged
Merged
Conversation
Patterns, the Calls tab and Test a number now show the place a pattern
covers or a number is from ("Arizona", "Ontario, Canada", "Jamaica",
"London, United Kingdom"), using the offline geocoding data in Google's
libphonenumber. It's only used on screen, never while screening a call,
and is warmed up in the background when the UI starts.
Closes #13
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Shows the place a pattern covers or a number comes from:
602*shows Arizona,876*Jamaica,+44*United Kingdom and+4420*London, United Kingdom. Nothing is shown when the pattern has too few digits to tell, such as60*or*.Oct 21, 10:47 AM · Arizona · matches 602*.(416) 555-0100 (Ontario, Canada) would ring: no pattern matches it.How it works:
BlockerServicenever calls it, so screening speed is unchanged: 0–19 ms on the emulator.PlaceNames.WarmUp), so the first screen doesn't wait.Docs: README,
docs/using.md,docs/patterns.md, and a Privacy note indocs/how-it-works.md.Stacked on #16. This PR's base is
edit-pattern-note, so the diff shows only this change. When #16 is merged and its branch deleted, GitHub retargets this PR tomaster.Testing
PlaceNamesTests; all 181 tests pass.🤖 Generated with Claude Code