Skip to content

Migrated to Asphalt 5#48

Open
agronholm wants to merge 22 commits into
masterfrom
asphalt5
Open

Migrated to Asphalt 5#48
agronholm wants to merge 22 commits into
masterfrom
asphalt5

Conversation

@agronholm

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Dec 30, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 99.51% (-0.5%) from 100.0%
when pulling 439c7c0 on asphalt5
into a4ab9ab on master.

Comment thread examples/attachment.py

async def start(self, ctx: Context) -> None:
async def start(self) -> None:
self.add_component(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to __init__?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this a data class and moved this code to __post_init__().

Comment thread examples/simple.py

async def start(self, ctx: Context) -> None:
async def start(self) -> None:
self.add_component(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants