Blacklist polygon rules should be treated as "all" in whitelist pass#57
Merged
Conversation
Contributor
Author
|
The failing test appears to be due to highway being both a blacklist and a whitelist. The blacklist seems redundant if there's already a whitelist. |
Contributor
Author
|
I see now why there's the extra blacklist for highway. I've pushed a better fix with test for the issue I'm seeing. All tests should now pass. This involves an extra loop through the polygon features list in the second pass for blacklists. |
Collaborator
|
Thank you for your work, this is looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding of blacklist rules is they are effectively "all with exceptions". The exceptions are handled in the first blacklist pass, so the second pass should treat them as all.
Example that should be a polygon (natural=water) https://www.openstreetmap.org/way/9641206
there is a natural=* tag and its value is not any of: no, coastline, cliff, ridge, arete nor tree_row;https://wiki.openstreetmap.org/wiki/Overpass_turbo/Polygon_Features