fix: normalize default dependency group name to underscores to prevent configuration mismatches#1077
Draft
xangcastle wants to merge 2 commits into
Draft
fix: normalize default dependency group name to underscores to prevent configuration mismatches#1077xangcastle wants to merge 2 commits into
xangcastle wants to merge 2 commits into
Conversation
✨ Aspect Workflows Tasks📅 Thu Jun 4 08:28:40 UTC 2026 ✅ 7 successful tasks
⏱ Last updated Thu Jun 4 08:32:38 UTC 2026 · 📊 GitHub API quota 150/15,000 (1% used, resets in 44m) |
xangcastle
force-pushed
the
xangcastle/normalize-groups-names-in-uv-hub
branch
3 times, most recently
from
d5faa65 to
79bb1d6
Compare
xangcastle
changed the title
xangcastle
force-pushed
the
xangcastle/normalize-groups-names-in-uv-hub
branch
from
79bb1d6 to
c824330
Compare
jbedard
reviewed
Jun 4, 2026
| @@ -0,0 +1,14 @@ | |||
| """Regression: rdflib must be importable on Linux. | |||
Member
There was a problem hiding this comment.
What makes this package unique that caused the bug? Outline it here...
jbedard
reviewed
Jun 4, 2026
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env bash | |||
| # Regression: dep_group config_setting names must be normalized (hyphens → underscores). | |||
Member
There was a problem hiding this comment.
Is the .sh really necessary? The rdflib_linux string is already in the BUILD and I think a comment at the top of the BUILD explaining why rdliflib_linux instead of rdflib-linux is enough and we can avoid the shell script?
Member
Author
There was a problem hiding this comment.
rdflib-linux is not enough bc instead of fail is skipped
…t configuration mismatches
xangcastle
force-pushed
the
xangcastle/normalize-groups-names-in-uv-hub
branch
from
c824330 to
0322c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are visible to end-users: yes/no
Test plan