fix: Change 3 to 4 in npm_package_store prefix len#2864
Open
oscar-meroton wants to merge 1 commit into
Open
Conversation
When calculating the length of the package store prefix for truncation, an extra slash after the repo name was unaccounted for, resulting in incorrect symlinks. Co-authored-by: Fredrik Medley <fredrik@meroton.com>
Member
|
@oscar-meroton sorry I didn't see this till now. How can we reproduce this in a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the package store prefix truncation with external modules (i.e. a repo name is included in the path), an extra slash after the repo name was unaccounted for, resulting in incorrect symlinks (and subsequently
ERR_MODULE_NOT_FOUNDerror during builds).Below is an example of the logic used to calculate the truncation length:
The extra
sin the beginning oftruncated_pathshould not be there and is solved by changing the+ 3to a+ 4.