Conversation
94e5860 to
0a0552c
Compare
|
concept ACK, it makes sense to leverage this CCR representation. However I can't seem to get any output. Every run has empty regarding file mode, if you mean using the -f flag, then #97 is relevant since it removes that flag (we decided to park the change for now). |
In
yeah, I looked into it again but I still think that making the reproduction run a bit slower is still better than changing our decision making. I hope they can fix this omitting of the values we are using in the context of |
I think I have fixed it, can you check if it works for you now? I will still need to spend a bit more time on it and make sure this is the way to do it. |
|
ACK 43f86d7 |
This is needed to use the CCR hashes feature which enables deterministic comparison of validated RPKI cache states across different validator instances.
|
I had to fix a typo in the readme that I introduced, so I think this is mergable. I didn't find a better approach for printing those hashes and it would be good to see them in action soon. |
This is an experiment with the suggestion from #96. This extracts the CCR hashes from
rpki-clientoutput. These hashes are potentially nicer to compare rpki cache contents because they deduplicate automatically for example.First downside is that we need to raise the minimum
rpki-clientversion to 9.6 because older versions don't have these CCR hashes. Second downside is that these are not being calculated in file mode in a way that is comparable afaict so we seem to need to do duplicate work in the case of reproduction runs. We can probably do this smarter and just get rid of file mode usage or maybe there is a way to get it to work in file mode, but I haven't spent enough time on this yet.I have only done shallow testing so far. At least with the additional
-Pparams the hashes have matched between the reproduction runs and the original downloads. Maybe that's making it worth to check the results on the latest run which has failed but I am not sure how actionable the results would be.