-
Notifications
You must be signed in to change notification settings - Fork 45
Add DSL-only mode: to_query_string + spread #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dblock
merged 14 commits into
ashkan18:master
from
rellampec:feature/dsl-mode-only-option
Jun 11, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cc010ad
feat: add Client#to_query_string and Query#spread
rellampec 8a56299
docs: move changelog entries to (Next) section, remove org-name header
rellampec 896c73d
fix: resolve CI failures — schema_path + rubocop offenses
rellampec d81578e
fix: make TCP error spec cross-platform (Windows/Linux)
rellampec c0225fc
chore: gitignore .vscode/ and .idea/ editor directories
rellampec d1ad529
chore: untrack CLAUDE.md + add to .gitignore
rellampec 1b6b000
fix: use WebMock to_rack for Ruby 3.1 CI compatibility
rellampec ad0f14c
fix: rubocop AsciiComments + Ruby 3.4 mutex_m + add 3.4 to CI matrix
rellampec 5712a3f
docs: document to_query_string and spread in README
rellampec 7e938a2
docs: fix CHANGELOG continuation line indentation (4 spaces)
rellampec 112a99d
docs: add PR #115 reference to CHANGELOG entries
rellampec 1bb7e26
chore: replace inline rubocop:disable with auto-gen-config, bump rubo…
rellampec 3129ba2
Merge branch 'master' into feature/dsl-mode-only-option
rellampec 1e9d77b
Update CHANGELOG.md
rellampec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,48 +1,72 @@ | ||
| # This configuration was generated by | ||
| # `rubocop --auto-gen-config` | ||
| # on 2018-08-14 17:57:21 -0400 using RuboCop version 0.56.0. | ||
| # on 2026-06-11 10:55:02 UTC using RuboCop version 1.87.0. | ||
| # The point is for the user to remove these configuration records | ||
| # one by one as the offenses are removed from the code base. | ||
| # Note that changes in the inspected code, or installation of new | ||
| # versions of RuboCop, may require this file to be generated again. | ||
|
|
||
| # Offense count: 1 | ||
| # Cop supports --auto-correct. | ||
| # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. | ||
| Gemspec/RequiredRubyVersion: | ||
| Exclude: | ||
| - 'graphlient.gemspec' | ||
|
|
||
| # Offense count: 1 | ||
| # Configuration parameters: AllowedMethods. | ||
| # AllowedMethods: enums | ||
| Lint/ConstantDefinitionInBlock: | ||
| Exclude: | ||
| - 'spec/graphlient/static_client_query_spec.rb' | ||
|
|
||
| # Offense count: 1 | ||
| Lint/MixedRegexpCaptureTypes: | ||
| Exclude: | ||
| - 'lib/graphlient/query.rb' | ||
|
|
||
| # Offense count: 1 | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| Lint/NonDeterministicRequireOrder: | ||
| Exclude: | ||
| - 'spec/spec_helper.rb' | ||
|
|
||
| # Offense count: 1 | ||
| # This cop supports safe autocorrection (--autocorrect). | ||
| # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions. | ||
| # NotImplementedExceptions: NotImplementedError | ||
| Lint/UnusedMethodArgument: | ||
| Exclude: | ||
| - 'lib/graphlient/adapters/http/http_adapter.rb' | ||
|
|
||
| # Offense count: 2 | ||
| Metrics/CyclomaticComplexity: | ||
| Max: 8 | ||
| # Offense count: 1 | ||
| # Configuration parameters: CountComments, CountAsOne. | ||
| Metrics/ClassLength: | ||
| Max: 104 | ||
|
|
||
| # Offense count: 1 | ||
| Metrics/PerceivedComplexity: | ||
| Max: 8 | ||
| # Configuration parameters: AllowedMethods, AllowedPatterns. | ||
| Metrics/CyclomaticComplexity: | ||
| Max: 9 | ||
|
|
||
| # Offense count: 1 | ||
| # Cop supports --auto-correct. | ||
| # Configuration parameters: AutoCorrect, EnforcedStyle. | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| # Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules. | ||
| # SupportedStyles: nested, compact | ||
| # SupportedStylesForClasses: ~, nested, compact | ||
| # SupportedStylesForModules: ~, nested, compact | ||
| Style/ClassAndModuleChildren: | ||
| Exclude: | ||
| - 'spec/graphlient/static_client_query_spec.rb' | ||
|
|
||
| # Offense count: 2 | ||
| Style/MethodMissingSuper: | ||
| Exclude: | ||
| - 'lib/graphlient/extensions/query.rb' | ||
| - 'lib/graphlient/query.rb' | ||
|
|
||
| # Offense count: 5 | ||
| # Offense count: 8 | ||
| Style/MultilineBlockChain: | ||
| Exclude: | ||
| - 'spec/graphlient/client_query_spec.rb' | ||
| - 'spec/graphlient/client_schema_spec.rb' | ||
|
|
||
| # Offense count: 39 | ||
| # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. | ||
| # URISchemes: http, https | ||
| Metrics/LineLength: | ||
| Max: 181 | ||
| # Offense count: 1 | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| # Configuration parameters: EnforcedStyle. | ||
| # SupportedStyles: literals, strict | ||
| Style/MutableConstant: | ||
| Exclude: | ||
| - 'lib/graphlient/query.rb' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,13 +6,13 @@ gem 'rake' | |
|
|
||
| group :development, :test do | ||
| gem 'activesupport', '< 6' | ||
| gem 'mutex_m' | ||
| gem 'mutex_m' # activesupport 5.x depends on mutex_m, removed from stdlib in Ruby 3.4 | ||
| gem 'ostruct' | ||
| end | ||
|
|
||
| group :development do | ||
| gem 'byebug', platform: :ruby | ||
| gem 'rubocop', '0.56.0' | ||
| gem 'rubocop', '~> 1.0' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is a gem and we don't check in Gemfile.lock, this should be locked to a specific version. Otherwise future CI runs will keep breaking without changes. |
||
| end | ||
|
|
||
| group :test do | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should commit an AGENTS.md!