fix: TOCTOU and improve error handling in evidence deletion#263
Open
jkennedyvz wants to merge 1 commit into
Open
fix: TOCTOU and improve error handling in evidence deletion#263jkennedyvz wants to merge 1 commit into
jkennedyvz wants to merge 1 commit into
Conversation
The deleteButtonClicked function had multiple issues: 1. TOCTOU race condition - checked file existence implicitly via QFile::remove return value, then deleted DB entry separately 2. Incomplete error handling - only reported file deletion failures, not database deletion failures 3. Inconsistent state - database entry deleted even if file deletion failed, leading to orphaned files Changes: - Perform both operations atomically (no race window) - Store results of both file and database deletion - Provide specific error messages for each failure scenario: * Both operations fail * Only file deletion fails (DB entry removed) * Only DB deletion fails (file removed) - Only close dialog if both operations succeed - Better UX with clear error messages and next steps This eliminates the TOCTOU vulnerability and prevents inconsistent state between filesystem and database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleteButtonClicked function had multiple issues:
Changes:
This eliminates the TOCTOU vulnerability and prevents inconsistent state between filesystem and database.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.