matlab: change map tile provider crg2html#122
Open
CarawaySeed42 wants to merge 1 commit into
Open
Conversation
OpenStreetMap blocks access if no referrer provided. When using html direct file access with a browser, this is not solvable and any alternative, like a local webserver, makes viewing the CRG refline on a map unneccessarily complicated. Switching the tile provider was the most sensible solution. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
CarawaySeed42
added
the
isState:ReadyforCCBreview
Contributor
Author
|
Since this topic was given higher priority from the OpenCRG CCB, the milestone was set to 2.0.1. And if anyone has any preference for a different map tile provider or different map style, like satellite images, let me know. |
Collaborator
|
Since this was not in the review for the TSC approval, we should not include it in 2.0.1. |
Contributor
Author
|
Understandable and thank you for changing the milestone of this PR to v2.1.0 for me. |
CarawaySeed42
force-pushed
the
matlab-change-map-tile-provider
branch
from
6a25651 to
2120360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenStreetMap blocks access if no referrer provided. When using html direct file access with a browser, this is not solvable and any alternative, like a local webserver, makes viewing the CRG refline on a map unneccessarily complicated.
Switching the tile provider to Carto was the most sensible solution.
Since OpenCRG is an open source project and the process of viewing single CRG reflines with a
map background generates barely any traffic, the use case should be within Carto's usage policy.
Resolves: #120