Skip to content

rename setting to allow_multiple_connections_per_peer_id#8373

Open
milahu wants to merge 2 commits into
arvidn:RC_2_0from
milahu:rename-to-allow_multiple_connections_per_peer_id
Open

rename setting to allow_multiple_connections_per_peer_id#8373
milahu wants to merge 2 commits into
arvidn:RC_2_0from
milahu:rename-to-allow_multiple_connections_per_peer_id

Conversation

@milahu
Copy link
Copy Markdown

@milahu milahu commented May 14, 2026

fix #8215 (comment)

not tested, feeling lucky : P

basically this is

rg -l allow_multiple_connections_per_pid |
xargs sed -i -E 's|(allow_multiple_connections_per)_pid|\1_peer_id|g'

git mv simulation/test_allow_multiple_connections_per_{pid,peer_id}.cpp

why?

  • make it consistent with the rest of the codebase: duplicate_peer_id etc
  • pid is okay for a local variable, but bad in a user-facing API

// a peer has multiple IP addresses, enabling this feature
// may improve transfer efficiency, but it may also
// increase network load.
allow_multiple_connections_per_pid,
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this released in the last release from 2.0.x? I was released in 2.1rc1, but that's probably fine to change. This is user facing so if it has been released we need to just add an alias

@arvidn
Copy link
Copy Markdown
Owner

arvidn commented May 15, 2026

if the existing name has not been included in a release yet, I think this change is reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants