rename setting to allow_multiple_connections_per_peer_id#8373
Open
milahu wants to merge 2 commits into
Open
Conversation
This was referenced May 14, 2026
arvidn
reviewed
May 15, 2026
| // a peer has multiple IP addresses, enabling this feature | ||
| // may improve transfer efficiency, but it may also | ||
| // increase network load. | ||
| allow_multiple_connections_per_pid, |
Owner
There was a problem hiding this comment.
was this released in the last release from 2.0.x? I was released in 2.1rc1, but that's probably fine to change. This is user facing so if it has been released we need to just add an alias
Owner
|
if the existing name has not been included in a release yet, I think this change is reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8215 (comment)
not tested, feeling lucky : P
basically this is
why?
duplicate_peer_idetcpidis okay for a local variable, but bad in a user-facing API