Skip to content

client: better handle errors from figma#113

Merged
donny-dont merged 1 commit into
arnemolland:mainfrom
donny-dont:feat-improve-client-error-handling
Jun 5, 2026
Merged

client: better handle errors from figma#113
donny-dont merged 1 commit into
arnemolland:mainfrom
donny-dont:feat-improve-client-error-handling

Conversation

@donny-dont

Copy link
Copy Markdown
Collaborator

Expand error handling to rate limits which gives information in the headers.

Parse the JSON value containing the error message.

@donny-dont donny-dont requested a review from arnemolland June 1, 2026 23:16
@donny-dont

Copy link
Copy Markdown
Collaborator Author

@arnemolland can you look at the HTTP/2 implementation specifically since you wrote that?

@arnemolland arnemolland left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Expand error handling to rate limits which gives information in the headers.

Parse the JSON value containing the error message.
@donny-dont donny-dont force-pushed the feat-improve-client-error-handling branch from 4c36be5 to 5651e8a Compare June 5, 2026 19:29
@donny-dont donny-dont merged commit 9279871 into arnemolland:main Jun 5, 2026
2 of 3 checks passed
@donny-dont donny-dont deleted the feat-improve-client-error-handling branch June 5, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants