Skip to content

Convert DispatchEvent() calls to EventCallback #91

Open

Description

@DavidThielen

At present the DispatchEvent() calls return a void. It would be better for them to return a ValueTask as the methods they call are generally synchronous, but in some cases async.

I'll take a stab at doing this if @arnaudleclerc or one of the other core contributors both says it's a good idea and will review my changes. From @rbrundritt comment, I think this should work fine.

Activity

  1. changed the title [-]Convert DispathcEvent() calls to return a ValueTask[/-] [+]Convert DispatchEvent() calls to return a ValueTask[/+] on Mar 24, 2024
  2. changed the title [-]Convert DispatchEvent() calls to return a ValueTask[/-] [+]Convert DispatchEvent() calls to EventCallback[/+] on Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions