fix(ci): revert broken PAT, make manifest bump non-fatal#37
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR merge workflow is simplified and hardened: the checkout step removes explicit token configuration to use GitHub Actions' default token, and the manifest push command now gracefully degrades on failure with a warning instead of halting the workflow. ChangesCheckout and Push Reliability
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the release workflow to avoid relying on an expired PAT and to let releases continue when manifest version bump pushes are blocked.
Changes:
- Removes the custom checkout token so
actions/checkoutuses the defaultGITHUB_TOKEN. - Makes the manifest bump
git pushbest-effort by converting push failure into a workflow warning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GH_PERSONAL_ACCESS_TOKEN is expired/invalid causing checkout to fail entirely. Revert to default GITHUB_TOKEN and make the manifest bump push non-fatal so the tag, goreleaser, S3 upload, and release proceed even if branch protection blocks the push. Signed-off-by: Ben <ben@armosec.io>
0cb1f1c to
2728e4c
Compare
Summary
GH_PERSONAL_ACCESS_TOKENis expired/invalid — checkout fails with "could not read Username"GITHUB_TOKENfor checkoutgit pushnon-fatal (|| warning) so the release (tag, goreleaser, S3, CloudFront) proceeds even if branch protection blocks the direct pushTest plan
releaselabel → v0.0.12 release completes successfullySummary by CodeRabbit